Skip to content

Migrate rustc_hir_analysis to session diagnostic [Part 5] #115821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2023
Merged

Migrate rustc_hir_analysis to session diagnostic [Part 5] #115821

merged 1 commit into from
Sep 29, 2023
+236 −125

Conversation

obeis
Copy link
Contributor

@obeis obeis commented Sep 13, 2023

Finishing coherence/builtin.rs file

@rustbot
Copy link
Collaborator

rustbot commented Sep 13, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 13, 2023
@bors
Copy link
Collaborator

bors commented Sep 15, 2023

☔ The latest upstream changes (presumably #115853) made this pull request unmergeable. Please resolve the merge conflicts.

@obeis obeis force-pushed the hir-analysis-migrate-diagnostics-5 branch from 1e084a9 to 49474eb Compare September 15, 2023 19:20
@obeis
Copy link
Contributor Author

obeis commented Sep 15, 2023

r? @compiler-errors

compiler-errors
compiler-errors reviewed Sep 16, 2023
View reviewed changes
@compiler-errors
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2023
@obeis obeis force-pushed the hir-analysis-migrate-diagnostics-5 branch 3 times, most recently from dd79ee6 to a5ccb35 Compare September 18, 2023 09:36
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 18, 2023
compiler-errors
compiler-errors requested changes Sep 18, 2023
View reviewed changes
@compiler-errors compiler-errors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2023
@obeis
Migrate rustc_hir_analysis to session diagnostic
77e205a 
Part 5: Finishing `coherence/builtin.rs` file
@obeis obeis force-pushed the hir-analysis-migrate-diagnostics-5 branch from a5ccb35 to 77e205a Compare September 20, 2023 07:56
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 20, 2023
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 28, 2023

📌 Commit 77e205a has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2023
@bors
Copy link
Collaborator

bors commented Sep 29, 2023

⌛ Testing commit 77e205a with merge 958c2b8...

@bors
Copy link
Collaborator

bors commented Sep 29, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 958c2b8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 29, 2023
@bors bors merged commit 958c2b8 into rust-lang:master Sep 29, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 29, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (958c2b8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.0% [0.9%, 1.2%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.7% [-4.7%, -4.7%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.8% [3.8%, 3.8%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.219s -> 630.657s (-0.09%)
Artifact size: 317.31 MiB -> 317.28 MiB (-0.01%)

@obeis obeis deleted the hir-analysis-migrate-diagnostics-5 branch September 29, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors requested changes

Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
6 participants
@obeis @rustbot @bors @compiler-errors @rust-timer @petrochenkov